Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Basic Windows setup #8208

Merged
merged 1 commit into from
Sep 17, 2019
Merged

ci: Basic Windows setup #8208

merged 1 commit into from
Sep 17, 2019

Conversation

lizan
Copy link
Member

@lizan lizan commented Sep 11, 2019

Signed-off-by: Lizan Zhou [email protected]

Description:
Setting up a job for Windows, this currently only build API build tests.

Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <[email protected]>
@lizan lizan marked this pull request as ready for review September 12, 2019 00:42
Copy link
Member

@junr03 junr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let me know if you want to kick up to another reviewer, or just an approve from me.

@junr03 junr03 self-assigned this Sep 12, 2019
@lizan
Copy link
Member Author

lizan commented Sep 12, 2019

cc @achasveachas This skips most of build_setup.ps1 / do_ci.ps1 but follows the mac pattern and much simpler, we can grow this script and combine them later.

@lizan
Copy link
Member Author

lizan commented Sep 16, 2019

@junr03 somehow the review disappeared, can you re approve?

@lizan lizan merged commit 931f4bb into master Sep 17, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Sep 24, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
@mattklein123 mattklein123 deleted the windows_ci branch October 15, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants